Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query.Executer.QueryResultSet now returns query.ClosableResultSet #1434

Merged
merged 4 commits into from
Sep 4, 2024
Merged

query.Executer.QueryResultSet now returns query.ClosableResultSet #1434

merged 4 commits into from
Sep 4, 2024

Conversation

asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented Sep 3, 2024 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

github.com/ydb-platform/ydb-go-sdk/v3/query

incompatible changes

Client.QueryResultSet: changed from func(context.Context, string, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.Execute) (github.com/ydb-platform/ydb-go-sdk/v3/internal/query/result.Set, error) to func(context.Context, string, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.Execute) (github.com/ydb-platform/ydb-go-sdk/v3/internal/query/result.ClosableResultSet, error)
Executor.QueryResultSet: changed from func(context.Context, string, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.Execute) (github.com/ydb-platform/ydb-go-sdk/v3/internal/query/result.Set, error) to func(context.Context, string, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.Execute) (github.com/ydb-platform/ydb-go-sdk/v3/internal/query/result.ClosableResultSet, error)

compatible changes

ClosableResultSet: added

summary

Base version: v3.77.2-0.20240904125700-8492468dd24f (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.78.0-rc3.

@asmyasnikov asmyasnikov force-pushed the closable-result-set branch 3 times, most recently from 6eb9e4d to f04fd6a Compare September 3, 2024 21:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.20%. Comparing base (8492468) to head (75b64a2).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/query/result.go 75.00% 2 Missing and 1 partial ⚠️
internal/query/result_set.go 88.88% 2 Missing ⚠️
internal/query/session.go 0.00% 1 Missing ⚠️
internal/query/transaction.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   67.32%   67.20%   -0.13%     
==========================================
  Files         351      350       -1     
  Lines       36511    36515       +4     
==========================================
- Hits        24582    24539      -43     
- Misses      10837    10867      +30     
- Partials     1092     1109      +17
Flag Coverage Δ
experiment 71.24% <83.33%> (-0.13%) ⬇️
go-1.21.x 67.49% <25.00%> (-0.04%) ⬇️
go-1.22.x 65.14% <25.00%> (-0.12%) ⬇️
go-1.23.x 67.15% <82.50%> (-0.13%) ⬇️
integration 52.07% <58.33%> (-0.18%) ⬇️
macOS 41.04% <75.00%> (+0.01%) ⬆️
ubuntu 71.46% <83.33%> (-0.17%) ⬇️
unit 41.47% <75.00%> (+<0.01%) ⬆️
windows 41.47% <75.00%> (+0.01%) ⬆️
ydb-23.3 46.88% <0.00%> (-0.21%) ⬇️
ydb-24.1 52.02% <58.33%> (-0.22%) ⬇️
ydb-nightly 71.24% <83.33%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@asmyasnikov asmyasnikov force-pushed the closable-result-set branch 3 times, most recently from 9c2db0c to 6c9b419 Compare September 4, 2024 11:24
@asmyasnikov asmyasnikov changed the title query.Executer.QueryResultSet now returns query.resultSetWithClose query.Executer.QueryResultSet now returns query.ClosableResultSet Sep 4, 2024
@asmyasnikov asmyasnikov merged commit bae85d1 into master Sep 4, 2024
41 checks passed
@asmyasnikov asmyasnikov deleted the closable-result-set branch September 4, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
query-service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmyasnikov @codecov-commenter